packages/ember-table/tests/integration/external-state.test.gts (1)

763-766: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Capture the table outside the tracked getter.

Assigning capturedTable as a side effect of a tracked getter couples the capture to render timing and makes the later capturedTable! assertions implicitly dependent on the template having rendered. A field-level capture is clearer and equally valid.

♻️ Suggested refactor

     class TableComponent extends Component {
       table = useTable(this, () => ({
         data: makeData(...UNSORTED.map((firstName) => ({ firstName }))),
         columns,
         features,
         atoms: { pagination: paginationAtom },
       }))
 
+      constructor(...args: ConstructorParameters<typeof Component>) {
+        super(...args)
+        capturedTable = this.table
+      }
+
       get pageSize() {
-        capturedTable = this.table
         return this.table.store.state.pagination.pageSize
       }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/ember-table/tests/integration/external-state.test.gts` around lines
763 - 766, Move the capturedTable assignment out of the tracked pageSize getter
and initialize it at field level when the table instance is created. Keep the
getter limited to returning this.table.store.state.pagination.pageSize, while
preserving the existing capturedTable assertions.

packages/lit-table/src/createTableHook.ts (1)

778-779: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Route header/footer through FlexRender too, for symmetry with AppCell.

cellFlexRender now delegates to FlexRender({ cell }) (Line 747), but header/footer still call flexRender(...) directly. Behavior is identical today (FlexRender's header/footer branches do exactly this per packages/lit-table/src/flexRender.ts:131-144), so this is purely about keeping one rendering entry point as FlexRender grows special cases.

♻️ Suggested refactor

-          const headerFlexRender = () =>
-            flexRender(header.column.columnDef.header, header.getContext())
+          const headerFlexRender = () => FlexRender({ header })

-          const footerFlexRender = () =>
-            flexRender(header.column.columnDef.footer, header.getContext())
+          const footerFlexRender = () => FlexRender({ footer: header })

Also applies to: 808-809

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/lit-table/src/createTableHook.ts` around lines 778 - 779, Update the
header and footer render helpers in createTableHook to delegate through
FlexRender using the appropriate header/footer props, matching cellFlexRender’s
FlexRender({ cell }) pattern. Replace the direct flexRender calls while
preserving the existing header and footer contexts and output behavior.

packages/lit-table/src/subscribe-directive.ts (1)

155-159: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicate render logic with createFakeHost().requestUpdate.

The value-render snippet here is identical to the one in requestUpdate (Lines 171-173). Extract a small private helper to keep both call sites in sync going forward.

♻️ Suggested extraction

+  private renderCurrentValue(): void {
+    if (this.resolvedTemplate && this.controller) {
+      this.setValue(this.resolvedTemplate(this.controller.value))
+    }
+  }
+
   /** Restores the controller subscription when the directive is re-attached to the DOM. */
   reconnected() {
     this.controller?.hostUpdate()
-    if (this.resolvedTemplate && this.controller) {
-      this.setValue(this.resolvedTemplate(this.controller.value))
-    }
+    this.renderCurrentValue()
   }

       requestUpdate: () => {
-        if (this.resolvedTemplate && this.controller) {
-          this.setValue(this.resolvedTemplate(this.controller.value))
-        }
+        this.renderCurrentValue()
       },

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/lit-table/src/subscribe-directive.ts` around lines 155 - 159,
Extract the duplicated resolved-template rendering logic from reconnected() and
requestUpdate into a small private helper, preserving the existing guards and
calls to setValue with controller.value. Replace both call sites with the helper
so future changes remain synchronized.